Bring in Poseidon implementation under cdk_erigon feature flag
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
muursh,
atanmarko and
LindaGuiga
as code owners
github-actions
bot
added
crate: evm_arithmetization
Nashtare
force-pushed
the
feat/poseidon_in_develop
branch
from
ba3942c to
26f2f8f
Compare
github-actions
bot
added
the
crate: proof_gen
Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Alonso Gonzalez <[email protected]>
Nashtare
force-pushed
the
feat/poseidon_in_develop
branch
from
26f2f8f to
86d7488
Compare
Nashtare
changed the title
evm_arithmetizationcdk_erigon feature flag
|
Ok from the |
LindaGuiga
approved these changes
Sep 5, 2024
0xaatif
reviewed
Sep 6, 2024
| @@ -64,7 +65,7 @@ parallel = [ | |||
| "starky/parallel", | |||
| ] | |||
| polygon_pos = [] | |||
| cdk_erigon = [] | |||
| cdk_erigon = ["smt_trie"] | |||
There was a problem hiding this comment.
But what does the feature mean?
There was a problem hiding this comment.
That we're targeting a cdk-based network, i.e like the current type2 zkEVM from Polygon Hermez, with the difference that we're a true type 2 (they have a custom set of opcodes).
We called the feature that way because the reference implementation is cdk_erigon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring feature-gated Poseidon-related code from the
type2_cancunbranch.Remaining follow-up work:
cdk_erigonfeatures of the whole e2e in the CI once it is completecloses #560